-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scalafix-rules_3 (GSoC 2022) #1643
Conversation
2a049b6
to
1fdbcb1
Compare
…eta quasiquotes for mod and init
1fdbcb1
to
c5e019b
Compare
rebased against #1629 to ease the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
We'll have to reflect on how to have different versions of https://github.com/scalacenter/scalafix/blob/main/scalafix-rules/src/main/resources/META-INF/services/scalafix.v1.Rule based on the scala version, as the presence of the reference to a non-existing ProcedureSyntax
will cause a runtime failure for
scalafix/scalafix-core/src/main/scala/scalafix/internal/v1/Rules.scala
Lines 101 to 108 in d6645da
def all(classLoader: ClassLoader): List[Rule] = { | |
import scala.jdk.CollectionConverters._ | |
ServiceLoader | |
.load(classOf[Rule], classLoader) | |
.iterator() | |
.asScala | |
.toList | |
} |
But this can be handled later, when working on unit3
.
Follows #1629
Part of the issues #1583 and #1680
Ready for review:
ExplicitResultTypes
(with all related dependencies) andProcedureSyntax
inscala-2
scala-2
TPrintImplicits
inscala-3
, exact copy as the one inscala-2.12+
rules3/compile
inci-3
check