support Scala 3 style wildcard import in RemoveUnused #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
force-pushed
the
issue-1663
branch
2 times, most recently
from
ea505d6 to
93666a4
Compare
bjaglin
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Thanks for the fix!
I wonder if this inconsistency is something we might want to fix upstream, in scalameta or in the compiter @tgodzik?
If not, I think we could leverage the testkit for such tests, by adding a inputSource3 sbt module (a bit like in organize-imports), and put input/output sources in scala-2.12+. I can do that as a follow-up PR @xuwei-k if you don't have time/interest to try that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Xsource:3#1663