Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RedundantSyntax.md #1697

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Update RedundantSyntax.md #1697

merged 2 commits into from
Oct 25, 2022

Conversation

kimnilsson
Copy link

Typo in RedundantSyntax.md

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to update the docs!

@@ -31,7 +31,5 @@ Example:
+ println("Bar")

- println(raw"Baz")
+ println("Foo")

println(raw"Foo\nBar")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent of that line was to show that this wouldn't get rewritten. Did you remove it on purpose?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was my intention as it broke the pattern of the preceding three examples (or well, that's how I read it at least). But perhaps it's a good idea to keep it but with a comment saying that it's not rewritten as raw is indeed used.

@kimnilsson
Copy link
Author

Thanks for taking the time to update the docs!

You've made it so easy with the Edit button so I thought why not 👍

Example of raw being used is back with a comment.
@bjaglin bjaglin merged commit 03d6768 into scalacenter:main Oct 25, 2022
@bjaglin
Copy link
Collaborator

bjaglin commented Oct 25, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants