-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure scala 3 dirs use scala3 dialect for scalafmt #1813
Conversation
Odd, |
🤯 #1784 (comment) (run just before scalafmt) does mutate the faulty 2 things remain mysterious to me:
|
Regarding the original trigger for this PR: we are actually back to green since yesterday. Failing runs (and failing runs only) have "ERROR Steward scalacenter/bloop-config failed", so I assume the problem is related to that. It's comforting that the output triggered by scala-3 files during steward's scalafmt run is not fatal, as
I am not sure what changed in bloop-config/steward on July 6th though... |
Yup, I noticed this as well. This is because a new release of steward came out with a fix for the actual error we were seeing. There still is an error for this one, but it doesn't fail the run. |
I think this is the cause of the error we're seeing in the [Scala Steward](https://github.com/scalacenter/steward/actions/runs/5470172748/jobs/9959938109#step:5:870) where the scala213 dialect has issues with the Scala 3 code. This small changes just adds in some fileOverrides to make sure the scala-3 dirs set the runner.dialect as scala3 instead of scala213.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
I think this is the cause of the error we're seeing in the Scala
Steward
where the scala213 dialect has issues with the Scala 3 code. This small
changes just adds in some fileOverrides to make sure the scala-3 dirs
set the runner.dialect as scala3 instead of scala213.