Revert "java target should only be driven by scalacOptions" #1862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1781 as there is no way to force a class file version with scala 2.12 (we can only use the
target
hint). JDK11 being the default JVM of the coursier version brought bycoursier/setup-action@v1
, 2.12 artifacts are no longer compatible with JDK8 🎱Identified through sbt-scalafix JDK8 CI when bringing-in the latest scalafix-interfaces: https://github.com/scalacenter/sbt-scalafix/actions/runs/6114939069/job/16597532534?pr=368. It would obviously be better to have a check in the CI here, but I am not sure it's really worth it as we have that safety net anyway.