Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-scalafix scalafixScalaBinaryVersion is now deprecated #1990

Merged
merged 1 commit into from
May 1, 2024

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented May 1, 2024

@bjaglin bjaglin force-pushed the scalafixScalaBinaryVersion213 branch from 8e9382b to 41f9c75 Compare May 1, 2024 12:39
@@ -56,11 +56,10 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys {
}

val prevVersions = previousVersions(sv).map(prev => TargetAxis(prev))
val scala3FromScala2 = TargetAxis(scala3)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seemed a bit unnecessary/overkill, so I specialized it to reduce build complexity and test time

 sbt:scalafix> projects
 [info] In file:/home/brice/git/scala/scalafix/
 [info] 	   cli2_12
 [info] 	   cli2_13
 [info] 	   cli3
 [info] 	   core2_12
 [info] 	   core2_13
 [info] 	   core3
 [info] 	   docs2_13
 [info] 	   expect2_12Target2_12_18
 [info] 	   expect2_12Target2_12_19
 [info] 	   expect2_12Target2_12_19xsource3
-[info] 	   expect2_12Target3_4_1
 [info] 	   expect2_13Target2_13_12
 [info] 	   expect2_13Target2_13_13
 [info] 	   expect2_13Target2_13_14
 [info] 	   expect2_13Target2_13_14xsource3
 [info] 	   expect2_13Target3_4_1
 [info] 	   expect3Target3_4_1
 [info] 	   input2_12_18
 [info] 	   input2_12_19
 [info] 	   input2_12_19xsource3
 [info] 	   input2_13_12
 [info] 	   input2_13_13
 [info] 	   input2_13_14
 [info] 	   input2_13_14xsource3
 [info] 	   input3_4_1
 [info] 	   integration2_12
 [info] 	   integration2_13
 [info] 	   integration3
 [info] 	   interfaces
 [info] 	   output2_12_19
 [info] 	   output2_12_19xsource3
 [info] 	   output2_13_14
 [info] 	   output2_13_14xsource3
 [info] 	   output3_4_1
 [info] 	   reflect2_12
 [info] 	   reflect2_13
 [info] 	   reflect3
 [info] 	   rules2_12
 [info] 	   rules2_13
 [info] 	   rules3
 [info] 	 * scalafix
 [info] 	   shared2_12
 [info] 	   shared2_13
 [info] 	   shared3
 [info] 	   testkit2_12
 [info] 	   testkit2_13
 [info] 	   testkit3
 [info] 	   unit2_12
 [info] 	   unit2_13
 [info] 	   unit3

@bjaglin bjaglin force-pushed the scalafixScalaBinaryVersion213 branch from 41f9c75 to 52c3ff0 Compare May 1, 2024 13:05
@bjaglin bjaglin changed the title sbt-scalafix now runs scalafix with Scala 2.13 by default @bjaglin sbt-scalafix now runs with 2.13 unless it is against 2.12 sources May 1, 2024
@bjaglin bjaglin changed the title @bjaglin sbt-scalafix now runs with 2.13 unless it is against 2.12 sources sbt-scalafix now runs with 2.13 unless it is against 2.12 sources May 1, 2024
@bjaglin bjaglin marked this pull request as ready for review May 1, 2024 13:23
@bjaglin bjaglin changed the title sbt-scalafix now runs with 2.13 unless it is against 2.12 sources sbt-scalafix scalafixScalaBinaryVersion is now deprecated May 1, 2024
@bjaglin bjaglin force-pushed the scalafixScalaBinaryVersion213 branch from 52c3ff0 to 909248c Compare May 1, 2024 15:22
@bjaglin bjaglin merged commit d0a8f3b into main May 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant