Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused attributes #2012

Merged
merged 1 commit into from
Jun 26, 2024
Merged

remove unused attributes #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions scalafix-core/src/main/scala/scalafix/internal/config/ScalafixConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,10 @@ import scala.meta._

import metaconfig._
import metaconfig.generic.Surface
import scalafix.Versions
import scalafix.internal.config.ScalafixConfig._

case class ScalafixConfig(
version: String = Versions.version,
Copy link
Collaborator Author

@bjaglin bjaglin Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added in #1101 but I don't understand why

debug: DebugConfig = DebugConfig(),
groupImportsByPrefix: Boolean = true,
fatalWarnings: Boolean = true,
reporter: ScalafixReporter = ScalafixReporter.default,
patches: ConfigRulePatches = ConfigRulePatches.default,
scalaVersion: ScalaVersion = ScalaVersion.scala2,
Expand Down
6 changes: 3 additions & 3 deletions scalafix-tests/unit/src/test/scala/scalafix/tests/config/ScalafixConfigSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class ScalafixConfigSuite extends munit.FunSuite {
}
}
check(
"version",
"version = abba",
ScalafixConfig(version = "abba")
"groupImportsByPrefix",
"groupImportsByPrefix = true",
ScalafixConfig(groupImportsByPrefix = true)
)
}