Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how users can customize linting behavior of rules #2062

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Aug 31, 2024

Closes #2000

@bjaglin bjaglin force-pushed the docs-lint-behavior branch 2 times, most recently from 90b6378 to 180421a Compare September 1, 2024 00:01
```
scalafix ... \
--settings.DisableSyntax.noFinalize=true \
--settings.lint.error.includes=.* \
Copy link
Collaborator Author

@bjaglin bjaglin Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a shell context, this needs to be wrapped in single quotes so that * is not processed.

Suggested change
--settings.lint.error.includes=.* \
'--settings.lint.error.includes=.*' \

However, this syntax is not supported on sbt-scalafix, so I'd rather document the sbt-scalafix one, and let CLI power users figure out by themselves (instead of being very verbose about it here and confusing sbt-scalafix users).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that multiline syntax does not work on sbt, so I am taking back what I wrote above and will target CLI/shell syntax instead in another PR

@bjaglin bjaglin marked this pull request as ready for review September 1, 2024 00:16
@bjaglin bjaglin merged commit 0643e8e into scalacenter:main Sep 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for non-zero exit codes from CLI when there are warnings
1 participant