Issue 319 #444
Merged
Issue 319 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
suggested changes
Nov 17, 2017
|
|
||
| test("Prev returns the firstToken when is given the firstToken") { | ||
| val tokens = "".tokenize.get // this contains two tokens: beginningOfFile and endOfFile | ||
| val firstToken = tokens.last |
| @@ -53,7 +53,7 @@ class TokenList(tokens: Tokens) { | |||
|
|
|||
| def prev(token: Token): Token = { | |||
| tok2idx.get(token) match { | |||
| case Some(i) if tokens.length > i - 1 => | |||
| case Some(i) if i - 1 > 0 => | |||
There was a problem hiding this comment.
tokens(0) should be possible
| @@ -53,7 +53,7 @@ class TokenList(tokens: Tokens) { | |||
|
|
|||
| def prev(token: Token): Token = { | |||
| tok2idx.get(token) match { | |||
| case Some(i) if tokens.length > i - 1 => | |||
There was a problem hiding this comment.
Nice catch! Bad copy paste 😅
| import scala.meta._ | ||
| import scalafix.util.TokenList | ||
|
|
||
| class TokenListTest extends FunSuite { |
| } | ||
|
|
||
| test("Slice gives an empty list with same token as inputs") { | ||
| val tokens = "val x = 2".tokenize.get |
There was a problem hiding this comment.
do we need val x = 2? It seems like we could reuse the same "".tokenize.get by putting in the top of the suite before the first test. That would to write small and declarative tests without duplicating new TokenList(..) in every unit test.
|
Sorry, I rushed a bit XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319
Thanks to @GoldenZero