ExplicitResultTypes: skip local implicits #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
suggested changes
Nov 17, 2017
| nm: Name, | ||
| mods: Traversable[Mod], | ||
| body: Term, | ||
| printLocalTypes: Boolean)(implicit ev: Extract[D, Mod]): Boolean = { |
There was a problem hiding this comment.
is printLocalTypes required? Seems config.skipLocalImplicits is only used as the argument
| case None => false | ||
| } | ||
|
|
||
| isImplicit && (if (printLocalTypes) !isLocal else true) || { |
There was a problem hiding this comment.
I would prefer to keep this boolean condition as simple as possible and delegate logic to local defs. We can move this if/else into isLocal
| @@ -125,16 +134,16 @@ case class ExplicitResultTypes( | |||
| } | |||
|
|
|||
| ctx.tree.collect { | |||
| case t @ Defn.Val(mods, _, None, body) | |||
| if isRuleCandidate(t, mods, body) => | |||
| case t @ Defn.Val(mods, Seq(Pat.Var(name)), None, body) | |||
There was a problem hiding this comment.
nitpick, scalameta trees only use List, conventionally we would pattern match this like Pat.Var(name) :: Nil
olafurpg
changed the title
olafurpg
approved these changes
Nov 20, 2017
| ### Configuration | ||
|
|
||
| ```scala | ||
| ExplicitResultTypes.memberKind = [Val, Def, Var] | ||
| ExplicitResultTypes.memberVisibility = [Public, Protected] | ||
| ExplicitResultTypes.memberKind = [Val, Def, Var] // empty by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34