Implement new patch infrastructure. #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
force-pushed
the
organize-imports
branch
2 times, most recently
from
e3b83f9 to
91561ea
Compare
Main changes:
- Patch(from, to, replace) replaced with TokenPatch(token, newToken)
with helpful combinators such as Add{Left,Right}
- New high-level TreePatch datatype with can be converted to TokenPatch.
- Implemented two tree patches, AddGlobalImport and RemoveGlobalImport.
- Implemented OrganizeImport, which is a prerequisite to use import tree
patches.
- OrganizeImports
- orders imports by configurable groups
- removes unused imports using scalac -Ywarn-unused-import
infrastructure. The implementation is requires hijacking a few
private fields in g.analyzer using evil reflection hackery.
- option to expand relative imports
- handles renames
- configurable "always used" to force keeping an import such as
acyclic.file
Known bugs:
- introduces false import on non-existing cats.data.UUID in circe
- makes an import unused by expanding relative imports to
fully-qualified imports, requiring you to run scalafix
twice to fully remove unused imports (e.g. in cats with
-Ywarn-unused-import)
- crashes on scala.meta parser bug (in akka), not scalafix problem
really.
Expand relative
Test that patch is unchanged
olafurpg
force-pushed
the
organize-imports
branch
from
91561ea to
89fa904
Compare
|
Can't reopen this PR, new #46 |
bjaglin
pushed a commit
to liancheng/scalafix
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is too big, I'm sorry. Main changes:
with helpful combinators such as Add{Left,Right}
patches.
infrastructure. The implementation is requires hijacking a few
private fields in g.analyzer using evil reflection hackery.
acyclic.file
Known bugs:
fully-qualified imports, requiring you to run scalafix
twice to fully remove unused imports (e.g. in cats with
-Ywarn-unused-import)
really.
Expand relative
Test that patch is unchanged