Fix false positives in testkit #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
commented
Dec 6, 2017
| @@ -205,7 +205,7 @@ object Patch { | |||
| case _: LintPatch => hasLintMessage = true | |||
| case _ => onlyLint = false | |||
| } | |||
| hasLintMessage && onlyLint | |||
| patch.isEmpty || hasLintMessage && onlyLint | |||
There was a problem hiding this comment.
I wrote an empty syntactic rule and I ran the SemanticSuite. It complained it was missing an output. This is because it checks if there are lint messages. It's obviously not the best way to fix this.
…xpected when assertions are empty this would make a test pass if * there are asserts but no reported messages * there are reported messages but not asserts
MasseGuillaume
force-pushed
the
teskit-empty-assertdiff
branch
from
973b6ef to
7e2e559
Compare
olafurpg
changed the title
olafurpg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olafurpg look what I found :p
I should always test edge cases.