Add noUniversalEquality option to DisableSyntax #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Sep 20, 2018
scalafix-rules/src/main/scala/scalafix/internal/rule/DisableSyntax.scala
Outdated
Show resolved
Hide resolved
olafurpg
reviewed
Sep 20, 2018
scalafix-rules/src/main/scala/scalafix/internal/rule/DisableSyntax.scala
Outdated
Show resolved
Hide resolved
olafurpg
reviewed
Sep 21, 2018
scalafix-rules/src/main/scala/scalafix/internal/rule/DisableSyntax.scala
Outdated
Show resolved
Hide resolved
olafurpg
approved these changes
Sep 21, 2018
| "Reporter message for noUniversalEquality" | ||
| ) | ||
| noUniversalEqualityMessage: String = | ||
| "Universal equality should be avoided since it's not typesafe", |
There was a problem hiding this comment.
We may want to refine this message down the road, but it's not blocking
There was a problem hiding this comment.
I'm open to suggestions :)
There was a problem hiding this comment.
== is unsafe since it allows comparing two unrelated types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #874
I hacked this together in 10 minutes, so I may be missing some edge cases.
I've explicitly restricted the rule to infix applications of==as I don't think handling non-infix applications (e.g.,1.==(2)) is worth the (albeit low) effort.