Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed test demonstrates the problem of #921 #922

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Failed test demonstrates the problem of #921 #922

merged 2 commits into from
Jan 30, 2019

Conversation

NicolasRouquette
Copy link
Contributor

No description provided.

@NicolasRouquette
Copy link
Contributor Author

The new --auto-classpath test failed as expected; e.g.:
https://travis-ci.org/scalacenter/scalafix/jobs/468266586#L673

@NicolasRouquette
Fixes required for --auto-classpath:
b67e5ea 
- Configure the symbol table with the validated classpath
- For --auto-classpath-roots, use both folders and '*.jar' files
olafurpg
olafurpg approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm so sorry for the terribly late response. I had not realized this PR included a fix! Good job tracking down the issue and fixing it.

@olafurpg olafurpg merged commit 0f1afb5 into scalacenter:master Jan 30, 2019
@olafurpg olafurpg mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasRouquette @olafurpg