Expose all synthetic semantic trees #981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimized lookup only exposed the last tree for a given position. A position can have multiple synthetic semantic trees. This occurs when we have a function with only an implicit argument.
Given the code:
The tree for the
foo.baz
looks like this:When calling
term.synthetic
on theTerm
we're not able to extract the implicit arguments. If we add parentheses,foo.baz()
, it will be wrapped in aTerm.Apply
, where the implicit is available. When querying the semantic tree from the given position we're ending up with two results where scalafix has optimized the lookup and expects at most one result.This change exposes all the semantic trees that are available in the given position. It also depricates the API where we're expecting zero or one result.