Scala 3 JS modifier #504
Scala 3 JS modifier #504
Conversation
| scalaJSLinkerConfig ~= { | ||
| _.withModuleKind(ModuleKind.CommonJSModule) | ||
| }, | ||
| libraryDependencies ++= List( | ||
| "org.scala-js" %%% "scalajs-dom" % scalajsDom | ||
| "org.scala-js" %%% "scalajs-dom" % scalajsDom cross CrossVersion.for3Use2_13 |
There was a problem hiding this comment.
DOM library won't be published for Scala 3.
| @@ -409,7 +406,9 @@ lazy val js = project | |||
| "org.scala-js" % "scalajs-compiler" % scalajs cross CrossVersion.full, | |||
| "org.scala-js" %% "scalajs-linker" % scalajs | |||
| ), | |||
| if3 = List() | |||
| if3 = List( | |||
| "org.scala-js" %% "scalajs-linker" % scalajs cross CrossVersion.for3Use2_13 | |||
There was a problem hiding this comment.
After we obtain sjsir files, it doesn't matter which linker we use.
| compat = Map( | ||
| "3.0" -> | ||
| """ | ||
| |-error: compile-only-error.md:3:17: |
There was a problem hiding this comment.
Hmm. This is not right.
There was a problem hiding this comment.
Right. Seems like it's because the scala binary version has changed for 3.0.0 stable - so our tests aren't actually verifying Scala 3 assertions :-/
| assertNoDiff( | ||
| Compat(obtainedErrors, compat, postProcessObtained), | ||
| Compat(obtainedErrors, Map.empty, postProcessObtained), |
There was a problem hiding this comment.
I looked at this and couldn't quite understand - my thinking is that we don't want to apply compat layers to obtained output, otherwise it resolves to the expectation itself and the test trivially passes (which was the reason that before some of the tests for errors were not doing anything)
Closes #500
Enable JS modifier for Scala 3
What helps here is that mdoc SBT plugin already collects all of the info that ScalaJS needs - Scala.js' own SBT plugin configures the scalacOptions and libraryDependencies depending on Scala version: #504
Which means that it's mostly a game of jenga to arrange the types + fixing a bug in
compileSourcesto reset the context correctly.Fix compat messages in tests
checkErrorwe were applying compat to both the obtained errors and expectations - which means with overrides those were always passing.