Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable running on Java 17 #541

Merged
merged 5 commits into from
Aug 6, 2021
Merged

Enable running on Java 17 #541

merged 5 commits into from
Aug 6, 2021

Conversation

sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Aug 6, 2021 •
edited
Loading

Before this path, mdoc keeps crashing with

[info] running (fork) mdoc.Main 
[error] java.lang.NoSuchFieldException: ucp
[error] 	at java.base/java.lang.Class.getDeclaredField(Class.java:2549)
[error] 	at mdoc.internal.CompatClassloader$.getURLs(CompatClassloader.scala:29)

As seen for example here
https://github.com/eikek/emil/pull/233/checks?check_run_id=3260441241#step:6:450
eikek/emil#233

@sideeffffect sideeffffect changed the title Test on Java 17 Enable running on Java 17 Aug 6, 2021
tgodzik
tgodzik approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the tests and fixing the JDK 17 issues! Also following up in Metals about this.

@tgodzik tgodzik merged commit eecf758 into scalameta:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideeffffect @tgodzik