Fix crash block capturing expressions #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
Aug 23, 2021
| @@ -12,6 +12,7 @@ import mdoc.Reporter | |||
| import mdoc.internal.cli.InputFile | |||
| import java.nio.file.Path | |||
| import mdoc.internal.cli.Settings | |||
| import scala.collection.immutable | |||
There was a problem hiding this comment.
Suggested change
| import scala.collection.immutable |
olafurpg
reviewed
Aug 23, 2021
| .append(") {\n") | ||
|
|
||
| section.source.stats.foreach { stat => | ||
| sb.append(stat.pos.text).append("\n") |
There was a problem hiding this comment.
Might want to add a semicolon just in case.
keynmol
force-pushed
the
fix-crash-block
branch
from
2ca7b59 to
a4f927d
Compare
keynmol
force-pushed
the
fix-crash-block
branch
from
a4f927d to
e3cdf6c
Compare
|
I'm just fighting exact same problem as @tgodzik was: #512 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
Putting this on CI to make sure it's not my laptop that is behaving weirdly (it fixes the original issue, btw)
TODO: