MarkdownPart: move to separate mdoc-parser module #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalafmt has an own markdown parser, to be able to format any scala code found in fenced blocks. In addition to duplicating functionality in that parser, it also doesn't support indented code blocks. Let's instead extract the parser portion of the mdoc logic into a module so that it can be re-used. That module will have no dependencies.
|
@tgodzik fyi, in case you missed this :) |
|
One minor thing is due to the last update we need to release on JDK 11 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalafmt has an own markdown parser, to be able to format any scala code found in fenced blocks. In addition to duplicating functionality in that parser, it also doesn't support indented code blocks.
Let's instead extract the parser portion of the mdoc logic into a module so that it can be re-used. That module will have no dependencies.
Helps with scalameta/scalafmt#3672.