Gracefully handle position conversion errors #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, mdoc failed with an exception when converting bogus positions reported by the compiler. Now we fall back to `Position.None` instead, which means the message is reported without a caret. The best long-term solution is probably to reconsider the architecture for how `fail` modifiers are compiled. The design in https://github.com/olafurpg/mdoc/issues/95#issuecomment-426993507 is both simpler than the current macro-based design and should also produce consistent errors with the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mdoc failed with an exception when converting bogus
positions reported by the compiler. Now we fall back to
Position.Noneinstead, which means the message is reported without a caret.
The best long-term solution is probably to reconsider the architecture
for how
failmodifiers are compiled. The design inhttps://github.com/olafurpg/mdoc/issues/95#issuecomment-426993507 is
both simpler than the current macro-based design and should also
produce consistent errors with the compiler.