Tweaks #277
Merged
Tweaks #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than loading the JARs in a URLClassLoader, then getting the sources via getResource. The former works fine in native-image in particular, unlike the latter.
Rather than putting them in a zip, then putting that zip in the JAR. This allows not to write the assets in a temporary directory upon startup.
Have cli depends on server, rather than the opposite.
|
It seems we can even just cut the dependency between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes that I found useful when embedding metabrowse in a custom application (that uses native-image).
The first commit is required for native-image. It loads sources from JARs using
ZipFile, rather than via aURLClassLoaderthat doesn't work fine from the native image.The second commit embeds the assets directly in the server JAR, under
metabrowse/server/assets/, rather than zipping them, embedding the zip in JAR, and unzipping it in a temporary directory every time upon start-up.The third commit reverses the dependency between
serverandcli- the latter isn't needed when embedding metabrowse in a custom app. Thanks to it, depending on metabrowse-server doesn't pull case-app, json4s, etc.