Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish server and cli modules with full cross version suffix #300

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

alexarchambault
Copy link
Contributor

So that downstream users don't risk running into class path issues because of a mismatch between the Scala version used by metabrowse and theirs.

This has been a problem in almond in particular. Almond is cross-compiled for several 2.12.x and 2.13.x versions, and had to:

  • resort to only use metabrowse in some of those (with annoying-to-maintain cross-sources for when metabrowse is available or not)
  • guess which Scala versions are still compatible with metabrowse or not (the mismatch is an issue only for some Scala versions)

So that downstream users don't risk running into class path issues
because of a mismatch between the Scala version used by metabrowse and
theirs.
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM makes sense!

@alexarchambault alexarchambault merged commit f4902be into scalameta:master Oct 10, 2021
@alexarchambault alexarchambault deleted the full-cross-version branch October 10, 2021 09:34
@alexarchambault
Copy link
Contributor Author

Going to cut a release with that, unless anyone opposes it.

@olafurpg
Copy link
Member

Do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants