Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document reason for ignore-engines [CI SKIP] #92

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Document reason for ignore-engines [CI SKIP] #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ before_install:
- nvm install "$TRAVIS_NODE_VERSION"
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version "$TRAVIS_YARN_VERSION"
- export PATH=$HOME/.yarn/bin:$PATH
# To avoid "engine node is incompatible with this version"
# See https://github.com/facebook/create-react-app/issues/4367#issuecomment-384667501
- yarn config set ignore-engines true

before_cache:
Expand Down
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ git clone https://github.com/scalameta/metadoc.git
cd metadoc
git submodule init
git submodule update

npm install -g yarn
yarn config set ignore-engines true # To avoid error: engine node is incompatible with this version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for the upath dependency? I ended up using nvm to install node version 9.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was upath. I have node v10 installed, ignoring the warning fixed the problem so I'm happy 😊


sbt
> metadoc-site # generate static site under target/metadoc.
> js/fastOptJS::startWebpackDevServer # spin up local file server that listens for changes.
Expand Down