Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanBuildFromDecoder: support any Map type #117

Merged
merged 5 commits into from
May 18, 2021
Merged

CanBuildFromDecoder: support any Map type #117

merged 5 commits into from
May 18, 2021

Conversation

kitbellew
Copy link
Contributor

@kitbellew kitbellew commented May 17, 2021 •
edited
Loading

Prerequisite for scalameta/scalafmt#2511.

@kitbellew kitbellew force-pushed the 117 branch 4 times, most recently from a5fbde9 to 6515347 Compare May 17, 2021 20:51
@kitbellew kitbellew requested review from olafurpg, poslegm and tgodzik May 17, 2021 21:09
tgodzik
tgodzik approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew kitbellew merged commit f834e07 into scalameta:main May 18, 2021
@kitbellew kitbellew deleted the 117 branch May 18, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@olafurpg olafurpg Awaiting requested review from olafurpg

@poslegm poslegm Awaiting requested review from poslegm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitbellew @tgodzik