Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pprint to 0.7.1 #151

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Bump pprint to 0.7.1 #151

merged 2 commits into from
Jan 14, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 10, 2022

Pprint is currently released for 2.11/2.12/2.13 and 3

Pprint is currently released for 2.11/2.12/2.13 and 3
@kitbellew
Copy link
Contributor

[error] java.lang.NoSuchMethodError: pprint.TPrint$.make(Lscala/Function1;)Lpprint/TPrint;
[error] 	at mdoc.internal.cli.Settings$.<clinit>(Settings.scala:303)
[error] 	at mdoc.Main$.process(Main.scala:24)

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 10, 2022

[error] java.lang.NoSuchMethodError: pprint.TPrint$.make(Lscala/Function1;)Lpprint/TPrint;
[error] 	at mdoc.internal.cli.Settings$.<clinit>(Settings.scala:303)
[error] 	at mdoc.Main$.process(Main.scala:24)

Yeah, it seems I've run into a bit of circular dependency problem. This is caused by scalameta/mdoc#603 which itself is blocked by this. Trying to exclude pprint from the docs project deps, but that doesn't seem to be working yet.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 10, 2022

I removed the publishing of docusaurus for the time being, since it need the new mdoc.

@kitbellew
Copy link
Contributor

@keynmol וואָס פֿאַר קיינמאָל? :)

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 11, 2022

@olafurpg do you estimate any issues here?

@tgodzik tgodzik merged commit e5f4acf into scalameta:main Jan 14, 2022
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 14, 2022

doing a release right now since this has popped up in multiple places. I do hope that Haoyi will stop with the breaking changes 😅

@bjaglin
Copy link
Member

bjaglin commented Jan 22, 2022

I ran into this from scalacenter/scalafix#1522 (comment): the breaking changes of pprint surface in metaconfig 0.9.16, which cannot cope with classes built against earlier metaconfig (i.e. pre com-lihaoyi/PPrint#72).

I assume the bumps were triggered by scalameta/mdoc#602. What about starting up a 0.10.x line so that mdoc can move forward, while maintaining a binary-compatible 0.9.x?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 26, 2022

I ran into this from scalacenter/scalafix#1522 (comment): the breaking changes of pprint surface in metaconfig 0.9.16, which cannot cope with classes built against earlier metaconfig (i.e. pre com-lihaoyi/PPrint#72).

I assume the bumps were triggered by scalameta/mdoc#602. What about starting up a 0.10.x line so that mdoc can move forward, while maintaining a binary-compatible 0.9.x?

Should we actually inline pprint ourselves instead of using one that might change from time to time? This would avoid the issue I think?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 27, 2022

I am trying that approach here #154

That should work correctly with older rules also. What do you think @bjaglin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants