Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafix 0.11.0 #5304

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Scalafix 0.11.0 #5304

merged 2 commits into from
Jun 5, 2023

Conversation

bjaglin
Copy link
Member

@bjaglin bjaglin commented Jun 3, 2023

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work! Pretty amazing new release!

Do you want to add anything more or can we merge?

@bjaglin bjaglin marked this pull request as ready for review June 4, 2023 21:13
@bjaglin
Copy link
Member Author

bjaglin commented Jun 4, 2023

LGTM! Thanks for the great work! Pretty amazing new release!

Thanks, but this is just one of the user-facing outcome of the huge scalameta work from @kitbellew and you, keeping binary and source compatibility while evolving the trees 💪 🙇

I am gonna have a bit more free time in the upcoming months, I am looking forward to work a bit on Scalafix as I have been struggling to just keep up to date in the last months...

Do you want to add anything more or can we merge?

Ready to go 🚀 I wanted to double-check the code, as I am not very familiar with it and didn't run it myself. There is a val (organizeImportRule) that looked fishy, but it's just an historical name for the custom rules classloader, so I figured out I wouldn't touch it in this PR.

val organizeImportRule =
Try(
Embedded.rulesClasspath(rulesDependencies.toList)
).map { paths =>
val classloader = Embedded.toClassLoader(
Classpath(paths.map(AbsolutePath(_))),
scalafixClassLoader,
)
rulesClassloaderCache.update(scalfixRulesKey, classloader)
classloader
}
organizeImportRule

@tgodzik
Copy link
Contributor

tgodzik commented Jun 5, 2023

Ready to go rocket I wanted to double-check the code, as I am not very familiar with it and didn't run it myself. There is a val (organizeImportRule) that looked fishy, but it's just an historical name for the custom rules classloader, so I figured out I wouldn't touch it in this PR.

I think I forgot to change that yeah 😓 Thank you again!

@tgodzik tgodzik merged commit 4af609c into scalameta:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asterisk to underscore replacement when organizing imports in Scala 3
2 participants