bugfix: Auto imports in worksheets in Scala 3 #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
force-pushed
the
i6027
branch
2 times, most recently
from
8c8373b
to
1da8ec3
Compare
|
I think @tgodzik was suggesting to skip any top-level comments, that are not right above |
Previously we only skipped using directives, not we skip all comments at the file beginning which are not directly above class/object
tgodzik
approved these changes
Feb 15, 2024
| } | ||
| } | ||
| def scalaCliScStartOffset(text: String): Option[Int] = | ||
| scriptStartOffset(text, "/*<script>*/") |
There was a problem hiding this comment.
ScalaCLI uses <script> as a marker, where Ammonite uses <start>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the import would be inserted above using directives
fixes #6027