bugfix: Metals SqlSharedIndices.scala XDG path violation
#6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untainsYD
changed the title
SqlSharedIndices.scala XDG path violation
tgodzik
approved these changes
Sep 27, 2024
|
Thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #6801
It can be easily modified to fit specific project requirements, but the main idea is to follow the XDG Base Directory Specification, which Metals already does in most places except for this
SqlSharedIndicesclass.Update: I have used directories-jvm in the updated version, which was already present in the project. The SQL shared indices will be preserved across different platforms.
NOTES: maybe
MetalsProjectDirectoriesshould be used instead ofProjectDirectories, see bugfix: Don't hang on ProjectDirs