Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing string escaping for \r #258

Closed
non opened this issue Nov 17, 2020 · 2 comments
Closed

Missing string escaping for \r #258

non opened this issue Nov 17, 2020 · 2 comments

Comments

@non
Copy link
Contributor

non commented Nov 17, 2020

From cats-parse I'm seeing this output:

  + wsp rejects all but single char 0.001s
\n 0.0sf accepts
\n 0.003srejects all but
  + lwsp accepts all linear white space 0.011s

The original test names are "crlf accepts \r\n" and "crlf rejects all but \r\n".

I think munit is not escaping \r properly (although it does seem to escape \n). The caller can definitely fix this by escaping their own strings but it seems friendly to have munit do this (especially if test names contain unexpected characters).

olafurpg added a commit that referenced this issue Nov 18, 2020
Fix #258 - escape "non-visible" characters in test names.
@olafurpg
Copy link
Member

Thank you for reporting! This should be fixed in #261, the test report for a suite that stresses escaping now looks like this

Screenshot 2020-11-18 at 06 45 38

@olafurpg
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants