Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loss of output when buffering is enabled #408

Closed
rossabaker opened this issue Aug 30, 2021 · 5 comments
Closed

Loss of output when buffering is enabled #408

rossabaker opened this issue Aug 30, 2021 · 5 comments

Comments

@rossabaker
Copy link

I am inconsistently seeing successes, failures, and stack traces on CI under v0.7.28. Running a specific test locally, I can reliably see that the new output buffering is hiding success messages on a simple test.

buffering on: http4s/http4s@35c0d48:

org.http4s.MethodSuite:
[info] Passed: Total 32, Failed 0, Errors 0, Passed 32
[success] Total time: 8 s, completed Aug 30, 2021 5:20:39 PM

buffering off: http4s/http4s@229e01e:

org.http4s.MethodSuite:
  + Hash[Method]: hash.antisymmetry eq 0.051s
  + Hash[Method]: hash.hash compatibility 0.009s
  + Hash[Method]: hash.reflexivity eq 0.004s
  + Hash[Method]: hash.same as scala hashing 0.004s
  + Hash[Method]: hash.same as universal hash 0.004s
...
[info] Passed: Total 32, Failed 0, Errors 0, Passed 32
[success] Total time: 4 s, completed Aug 30, 2021 5:19:05 PM

This is an enormous build. I can try to minimize it if the cause is not immediately obvious. I'm excited about the new feature, and loving the library in general!
@rossabaker rossabaker mentioned this issue Aug 30, 2021
Merged
olafurpg added a commit to olafurpg/munit that referenced this issue Aug 31, 2021
@olafurpg
Attempt 1: make sure to always flush buffered logs
18b3e9f 
Previously, buffered logs would sometimes not get flushed resulting in
lost test report output. See scalameta#408. This commit adds an extra attempt to
flush the buffered logs inside the sbt testing framework in case the
logs don't get flushed by the JUnit test listener. I'm not 100% sure
this fixes the problem but it seems worth a short and it shouldn't cause
a regression.
@olafurpg olafurpg mentioned this issue Aug 31, 2021
Merged
@olafurpg
Copy link
Member

Thank you for reporting! I am able to reproduce the issue with a local clone of http4s at the commit http4s/http4s@35c0d48 I wasn't able to reproduce this inside the MUnit build but I took a blind stab at fixing this issue in #409. I'm unable to reproduce the issue in the http4s build after the fix so we can merge and release that commit

@olafurpg
Copy link
Member

I just cut a new 0.7.29 release that may take a few hours to become available on Maven Central

@olafurpg
Copy link
Member

0.7.29 is available now on Maven Central

@rossabaker
Copy link
Author

Thank you! It's working well for me.

@olafurpg
Copy link
Member

Great! Thank you for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossabaker @olafurpg