Regenerate default seed at every prop iteration #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @barambani |
gabro
commented
May 7, 2020
Comment on lines
+52
to
+59
| def seed = | ||
| scalaCheckTestParameters.initialSeed.getOrElse( | ||
| Seed.fromBase64(scalaCheckInitialSeed).get | ||
| ) | ||
| val result = check(scalaCheckTestParameters, prop.useSeed(test.name, seed)) | ||
| val result = check( | ||
| scalaCheckTestParameters, | ||
| Prop(genParams => prop(genParams.withInitialSeed(seed))) | ||
| ) |
There was a problem hiding this comment.
this way if the user hasn't overridden the default seed, we recompute it in the Prop lambda (which is what viewSeed does in vanilla ScalaCheck)
|
Thanks for the fix. This version works for all the tests I had. |
|
Thanks for confirming and thanks again for the detailed bug report. Having a reproduction test case has been really helpful in tracking this down |
olafurpg
reviewed
May 7, 2020
|
It’s possible to use println in framework suites just to check that each iteration has a unique value. |
|
Whoops, I actually had a test suite I forgot to commit 😅 doing it tomorrow |
|
Done now @olafurpg |
olafurpg
approved these changes
May 10, 2020
|
This fix has been released as v0.7.6. Thank you @barambani for reporting! |
|
Brilliant, Thank you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
This is extremely subtle, but it seems to work now