Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to sbt 1.4 #193

Merged
merged 1 commit into from
Sep 9, 2020
Merged

upgrade to sbt 1.4 #193

merged 1 commit into from
Sep 9, 2020

Conversation

SethTisue
Copy link
Contributor

I'm interested in seeing if your CI gives the same failure
that we saw at scala/community-build#1211

@SethTisue
Copy link
Contributor Author

hmm, CI likes it. okay, up to you if you want to close this and wait for sbt 1.4.0 final

@SethTisue
Copy link
Contributor Author

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@olafurpg olafurpg marked this pull request as ready for review September 9, 2020 06:55
@olafurpg olafurpg merged commit 4dc7b16 into scalameta:master Sep 9, 2020
@olafurpg
Copy link
Member

olafurpg commented Sep 9, 2020

I'm loving sbt 1.4, the new tab completions are amazing and the new BSP support is really promising!

@SethTisue SethTisue deleted the sbt-1.4 branch September 9, 2020 14:29
@SethTisue
Copy link
Contributor Author

reverted at #210 for Dotty-related reasons, we can try again later :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants