Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-build against Scala 3.0.0-M2 #265

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Cross-build against Scala 3.0.0-M2 #265

merged 1 commit into from
Nov 25, 2020

Conversation

gabro
Copy link
Member

@gabro gabro commented Nov 25, 2020 •
edited
Loading

Supersedes #264

Closes #263

@gabro gabro requested review from olafurpg and tgodzik November 25, 2020 09:22
This was referenced Nov 25, 2020
Closed
Closed
tgodzik
tgodzik reviewed Nov 25, 2020
View reviewed changes
munit/shared/src/main/scala-3/munit/internal/MacroCompat.scala Outdated
import qctx.tasty.{_, given _}
val path = rootPosition.sourceFile.jpath.toString
val startLine = rootPosition.startLine + 1
def locationImpl()(using Quotes): Expr[Location] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Quotes are not found, I also wonder if this will compile under previous versions? 3.0.0-M1 and 0.27.0-RC1?

I think we can drop 0.27.0-RC1, but we might need to have some campatibility utility classes after all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was stupid and I didn't consider M1. Should be fixed in the latest commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should drop 0.27-RC1 in this PR though, maybe we can discuss the consequences in a different issues

@gabro gabro force-pushed the scala-3.0.0-M2 branch 2 times, most recently from 798684c to 7f2726e Compare November 25, 2020 09:43
@gabro
Copy link
Member Author

gabro commented Nov 25, 2020

Ok, since the macro API seems to be evolving across dotty and scala milestones, I've opted for splitting MacroCompat across the specific Scala versions (0.27, 3.0.0-M1, 3.0.0-M2, etc) and leaving Compat in the shared scala-3 dir.

This is with the idea that once Scala 3 is stable we can get rid of most of them.

@gabro gabro requested a review from tgodzik November 25, 2020 10:10
olafurpg
olafurpg approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Feel free to cut a new release once merged

@gabro
Copy link
Member Author

gabro commented Nov 25, 2020

👍 I'll merge and cut a release and then we can discuss dropping 0.27

@gabro gabro merged commit 576b50c into scalameta:master Nov 25, 2020
@gabro gabro deleted the scala-3.0.0-M2 branch November 25, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.0.0-M2 release
3 participants
@gabro @olafurpg @tgodzik