-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to sbt 1.5.0 #344
Upgrade to sbt 1.5.0 #344
Conversation
🙀
|
@SethTisue Yeah, that's a known issue I've been avoiding to deal with. The account was @olafurpg's personal account and it expired IIRC. I will disable it for the time being. |
✅ 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you!
@SethTisue I think it's a cool idea to collect historical test reports but the MUnit implementation wasn't fully fleshed out. For example, there was no good way to properly query/filter the data if you only want a report for the last month or something like that.
Summary of the main changes (I've split them by commit to ease the review):
withDottyCompat
)MUnitReporterPluin
from our docs (sort of a followup of Remove documentation on how to setup test reports. #305), since it was blocking the CI due to invalid credentials