Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sbt 1.5.0 #344

Merged
merged 9 commits into from
Apr 6, 2021
Merged

Upgrade to sbt 1.5.0 #344

merged 9 commits into from
Apr 6, 2021

Conversation

gabro
Copy link
Member

@gabro gabro commented Apr 5, 2021

Summary of the main changes (I've split them by commit to ease the review):

  • Remove sbt-dotty in favor of native support (it requires replacing withDottyCompat)
  • Remove workaround for an sbt bug around semanticdb scalac options
  • Remove deprecated sbt syntax in favor of the new unified slash syntax
  • Switch from csbt to sbt on Windows CI (to fix a classloading issue)
  • Remove MUnitReporterPluin from our docs (sort of a followup of Remove documentation on how to setup test reports. #305), since it was blocking the CI due to invalid credentials
  • Update the getting started docs to add MUnit as a custom sbt test framework only on < 1.5.0

@gabro gabro mentioned this pull request Apr 5, 2021
@SethTisue
Copy link
Contributor

🙀

[error] com.google.cloud.storage.StorageException: The project to be billed is associated with a closed billing account.
[error] 	at com.google.cloud.storage.spi.v1.HttpStorageRpc.translate(HttpStorageRpc.java:233)

@gabro
Copy link
Member Author

gabro commented Apr 5, 2021

@SethTisue Yeah, that's a known issue I've been avoiding to deal with. The account was @olafurpg's personal account and it expired IIRC. I will disable it for the time being.

@gabro
Copy link
Member Author

gabro commented Apr 5, 2021

✅ 🎉

@gabro gabro marked this pull request as ready for review April 5, 2021 21:18
@gabro gabro requested a review from olafurpg April 5, 2021 21:18
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@SethTisue I think it's a cool idea to collect historical test reports but the MUnit implementation wasn't fully fleshed out. For example, there was no good way to properly query/filter the data if you only want a report for the last month or something like that.

@gabro gabro merged commit d2e4f0b into main Apr 6, 2021
@gabro gabro deleted the sbt1.5.0 branch April 6, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants