Concurrency fixes for junit-interface #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are unfixably broken for parallel execution which is the default in sbt. Addresses point 1) in scalameta#399, see that ticket for more details.
These types map 1:1 to suites/TaskDefs, which means that the complexity of some of the data structures can be avoided. Addresses point 2) in scalameta#399, see that ticket for more details.
jenshalm
force-pushed
the
concurrency-fixes
branch
from
e651d11 to
4a2fc95
Compare
|
The tests did not execute when I originally created the PR, I had to push a random change to actually trigger them. GitHub had issues earlier today, and apparently when checks don't execute during PR creation, they never will. |
olafurpg
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address both issues in #399 (in separate commits).
Regarding 2): I only removed multi-suite support from
EventDispatcherandRichLogger, not thread-safety.Some basic observation suggests that both classes are pinned to a thread, even with asynchronous tests, but I wasn't 100% certain that this is the case in all possible scenarios. Most of the possible simplification is already achieved by dropping multi-suite support, so maybe keeping thread-safety does not hurt.