Make flaky tag work with Scalacheck suites #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Scalacheck suite transform was registered after the `.flaky` transform so a flaky test would fail even if it was OK to ignore flaky failures. Reordering the transforms fixes the issue.
olafurpg
commented
Jan 6, 2022
| @@ -29,7 +29,7 @@ trait ScalaCheckSuite extends FunSuite { | |||
| implicit def unitToProp(unit: Unit): Prop = Prop.passed | |||
|
|
|||
| override def munitTestTransforms: List[TestTransform] = | |||
| super.munitTestTransforms :+ scalaCheckPropTransform | |||
| scalaCheckPropTransform +: super.munitTestTransforms | |||
There was a problem hiding this comment.
Feels like the discussions around transform registrations paid off big time. I was a big proponent for side-effecting transforms but that would have been a nightmare to debug for this bug here.
|
Mm the CI failure looks legit |
There was a bug in the JS/Native implementation of `RunNotifier` so that it would report that a test was both ignored and that it succeeded.
|
The test failure was a legitimate bug, which only got surfaced now because of the change. The problem was that the JS/Native test reporter reported that ignored tests also succeeded. |
olafurpg
added a commit
to olafurpg/munit
that referenced
this pull request
Jan 17, 2022
olafurpg
added a commit
to olafurpg/munit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Scalacheck suite transform was registered after the
.flakytransform so a flaky test would fail even if it was OK toignore flaky failures. Reordering the transforms fixes the issue.