Publish for Scala 3 + Native #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 3.0.x and pretend it never existed, use 3.1.x for JVM, JS and Native platforms
Scala 3 doesn't allow to call method with parentheses without them. Normally class can extends trait/interface and overwrite their def's using val/override val no matter if def was declared with or without parentheses. However for Scala 3 this is no llonger true. This PR uses a workaround with underscores.
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
Merged
armanbilge
commented
Apr 8, 2022
| addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.4.0") | ||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.6.0") | ||
| addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.4.4") | ||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.10.0") |
There was a problem hiding this comment.
Scala.js 1.10 is forward+backward compatible through Scala.js 1.8. So downstreams can stay on 1.8 if they wish and are not forced to upgrade.
This reverts commit b2d9743.
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
|
@armanbilge https://github.com/scalameta/munit/tree/series/0.7 is at your disposal. |
|
Green! Although credit where credit's due, I didn't contribute a single change to this PR 😂 |
|
On Discord we decided instead of backporting to 0.7.x it's time to cut a stable 1.0. So closing in favor of the other PR. |
jodersky
added a commit
to jodersky/ScalaPB
that referenced
this pull request
Aug 6, 2022
Since 0.4.4, Scala Native supports Scala 3. The update to the munit testing library was necessary because the 0.x series does not support Scala Native on 3 [1]. [1]: scalameta/munit#511
thesamet
pushed a commit
to scalapb/ScalaPB
that referenced
this pull request
Aug 6, 2022
Since 0.4.4, Scala Native supports Scala 3. The update to the munit testing library was necessary because the 0.x series does not support Scala Native on 3 [1]. [1]: scalameta/munit#511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes/backports (?) #477.
This PR is based against 92f3ad9 aka v0.7.29. This is so that these changes can be released as 0.7.30, instead of a milestone of 1.0.0 which the ecosystem has not yet adopted.
Since there are conflicts with subsequent changes on
main, I'll need aseries/0.7branch to target this to.