Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a StackOverflowError in addition to NonFatal errors #648

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

mzuehlke
Copy link
Contributor

if they are happening inside a test

I only execute the test on the JVM, because

  • on JS the error message is different
  • on Native the runner just terminates (I know too little about ScalaNative)

Fixes #583

if they are happening inside a test

I only execute the test on the JVM, because
- on JS the error message is different
- on Native the runner just terminates
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgodzik tgodzik merged commit 5d07eba into scalameta:main Apr 19, 2023
@mzuehlke mzuehlke deleted the issue-583 branch July 3, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown inside a test crashes the runner
2 participants