fix intercept for AssertionError #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to `intercept`and `AssertionError` till now the test passed successfully. This fix treats the FailException special.
tgodzik
approved these changes
Aug 1, 2023
|
Is there a reason that this pull request hasn't been merged, yet ? |
tgodzik
requested changes
Jan 2, 2024
Comment on lines
199
to
200
| if !T.runtimeClass.isAssignableFrom(e.getClass()) || | ||
| e.getMessage.contains(expectedExceptionMsg) => |
There was a problem hiding this comment.
maybe a separate case:
```suggestion
case failed: FailException if failed.getMessage() == expectedExceptionMsg =>
throw e
to be super sure? So that we only employ this logic if someone throws exactly the same error as we would. Then they're on their own
There was a problem hiding this comment.
There was a problem hiding this comment.
I totally forgot about this, @mzuehlke what do you think about suggested changes? I am ok also merging as is, we could update the test case though.
There was a problem hiding this comment.
I had forgotten about it, too. Sorry for that.
I adopted your suggestion.
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to
interceptanAssertionErrortill now the test passed successfully.This fix treats the FailException special.
closes: #679