Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatOps: enclosing parens owned by enclosed tree #3395

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

kitbellew
Copy link
Collaborator

@kitbellew kitbellew commented Nov 28, 2022

Regardless of how scalameta treats enclosing parens (whether owned by the tree they enclose, or by its parent), let's assign the enclosed tree as the owner. Exceptions include cases where parens are an integral part of the parent (tuple, if/while conditions etc.)

@kitbellew kitbellew requested a review from tgodzik November 28, 2022 17:35
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew kitbellew merged commit cdee46b into scalameta:master Nov 29, 2022
@kitbellew kitbellew deleted the 3395 branch November 29, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants