Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeOps: replace SplitAssignIntoParts with new Tree interfaces #3421

Merged
merged 1 commit into from
Dec 27, 2022
Merged

TreeOps: replace SplitAssignIntoParts with new Tree interfaces #3421

merged 1 commit into from
Dec 27, 2022

Conversation

kitbellew
Copy link
Collaborator

No description provided.

@kitbellew kitbellew requested a review from tgodzik December 23, 2022 21:35
@kitbellew kitbellew changed the title Use Tree.WithBody instead of SplitAssignIntoParts TreeOps: deprecate SplitAssignIntoParts Dec 25, 2022
tgodzik
tgodzik approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Though SplitAssignIntoParts is altogether removed, not deprecated, no?

@kitbellew
Copy link
Collaborator Author

LGTM!

Though SplitAssignIntoParts is altogether removed, not deprecated, no?

good point, will clarify.

@kitbellew
TreeOps: replace SplitAssignIntoParts
bb68e57 
Use the new Tree interfaces.
@kitbellew kitbellew changed the title TreeOps: deprecate SplitAssignIntoParts TreeOps: replace SplitAssignIntoParts with new Tree interfaces Dec 27, 2022
@kitbellew kitbellew merged commit 5641e0e into scalameta:master Dec 27, 2022
@kitbellew kitbellew deleted the 3421 branch December 27, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitbellew @tgodzik