Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveScala3OptionalBraces: allow leading infix op #3840

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

kitbellew
Copy link
Collaborator

Previously, we didn't allow it as the scalameta library didn't provide a way to check when it was actually possible. Helps with #3812.

Previously, we didn't allow it as the scalameta library didn't provide
a way to check when it was actually possible.
@kitbellew kitbellew requested a review from tgodzik March 16, 2024 14:45
judgment.toString
} + "."
this.match
case MateAdvice(seq, _, _, _) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have 3 spaces here? It should stay the same, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because significant indentation in this file is set to 3:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ach! Right

@kitbellew kitbellew merged commit 78bb7c8 into scalameta:master Mar 17, 2024
9 checks passed
@kitbellew kitbellew deleted the 3812_12 branch March 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants