MethodDescriptor: add input and output types #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree - it would be better to return the Descriptor. |
thesamet
reviewed
Apr 5, 2023
|
|
||
| lazy val inputType: Descriptor = { | ||
| val inputType = asProto.inputType.getOrElse( | ||
| throw new DescriptorValidationException(this, "missing method input type") |
There was a problem hiding this comment.
s"Missing method input type for method $fullName"
thesamet
reviewed
Apr 8, 2023
| ) | ||
| FileDescriptor | ||
| .find(containingService.file, this, inputType) | ||
| .getOrElse( |
There was a problem hiding this comment.
lets use pattern matching on case Some(d: Descriptor) to make the asInstanceOf unnecessary and handle the case that what's being found isn't a descriptor.
thesamet
reviewed
Apr 8, 2023
| FileDescriptor | ||
| .find(containingService.file, this, inputType) | ||
| .getOrElse( | ||
| throw new DescriptorValidationException(this, "couldn't build input type descriptor") |
There was a problem hiding this comment.
Couldn't ... for $fullName
thesamet
reviewed
Apr 8, 2023
| } | ||
|
|
||
| lazy val outputType: ScalaType = { | ||
| lazy val outputType: Descriptor = { | ||
| val outputType = asProto.outputType.getOrElse( | ||
| throw new DescriptorValidationException(this, "missing method output type") |
thesamet
reviewed
Apr 8, 2023
| .asInstanceOf[Descriptor] | ||
| ) | ||
| FileDescriptor | ||
| .find(containingService.file, this, outputType) |
There was a problem hiding this comment.
Same as earlier comments (capital letter, avoid asInstanceOf through pattern matching)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what it says on the tin.
on gitter, there was mention that these fields would maybe be better exposed as
ScalaTyperather than the message descriptor directly. while I don't think this makes a huge difference, I think it makes consuming the endpoint a little more cumbersome. iiuc protobuf method in/out types will always be messages. upcasting to the more generalScalaTypemeans calling code will just have to cast back down toScalaType.Messageto finally get at the underlyingDescriptor.I think a better alternative would be to return the
Descriptordirectly, since afaict wrapping it doesn't add value.Alternatively, the fields could be typed as
ScalaType.Messageto avoid the up & down casts.