-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nscplugin, sbt-scala-native to 0.5.1 #1682
Conversation
It looks like scala-collection-compat need to be updated to latest version too. |
Right. I pushed a commit to update to 2.12.0. |
Seems like munit needs to be updated too. I updated it to version 1.0.0-M11. \edit: now it's failing because mockito has been compiled with Java 11... |
Can you upgrade the JVM to Java 11 for this specific test target only? |
project/Dependencies.scala
Outdated
@@ -17,7 +17,7 @@ object Dependencies { | |||
val annotationApi = "1.3.2" | |||
val cats = "2.6.1" | |||
val mockito = "5.11.0" | |||
val munit = "1.0.0-M8" | |||
val munit = "1.0.0-M11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val munit = "1.0.0-M11" | |
val munit = "1.0.0-M12" |
we updated to newer version already, M11 might be broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 done.
5859e60
to
f49cdde
Compare
👌 done. Alternatively, how about downgrading mockito to 4.x? |
ping ... |
Releasing protobuf-scala-runtime 0.8.15 which support native 0.5. |
Shouldn't libraryDependencies += "com.thesamet.scalapb" %% "scalapb-runtime" % scalapb.compiler.Version.scalapbVersion % "protobuf" does not compile. |
* Update nscplugin, sbt-scala-native to 0.5.1 * Use `nativeConfig` to enable link stubs * Update scala-collection-compat to 2.12.0 * Update munit to 1.0.0-M12 * Use Java 11 to run `grpcRuntimeJVM*/test` * Bump protobuf-scala-runtime to 0.8.15 --------- Co-authored-by: Scala Steward <scala_steward@virtuslab.com> Co-authored-by: Nadav Samet <thesamet@gmail.com>
Please update to ScalaPB 0.11.17. |
nativeConfig
to enable link stubsAdapted from #1680