Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nscplugin, sbt-scala-native to 0.5.1 #1682

Merged
merged 6 commits into from
Apr 28, 2024

Conversation

avdv
Copy link
Contributor

@avdv avdv commented Apr 19, 2024

  • Update nscplugin, sbt-scala-native to 0.5.1
  • Use nativeConfig to enable link stubs

Adapted from #1680

@thesamet
Copy link
Contributor

It looks like scala-collection-compat need to be updated to latest version too.

@avdv
Copy link
Contributor Author

avdv commented Apr 20, 2024

It looks like scala-collection-compat need to be updated to latest version too.

Right. I pushed a commit to update to 2.12.0.

@avdv
Copy link
Contributor Author

avdv commented Apr 21, 2024

Seems like munit needs to be updated too. I updated it to version 1.0.0-M11.

\edit: now it's failing because mockito has been compiled with Java 11...

@thesamet
Copy link
Contributor

Can you upgrade the JVM to Java 11 for this specific test target only?

@@ -17,7 +17,7 @@ object Dependencies {
val annotationApi = "1.3.2"
val cats = "2.6.1"
val mockito = "5.11.0"
val munit = "1.0.0-M8"
val munit = "1.0.0-M11"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val munit = "1.0.0-M11"
val munit = "1.0.0-M12"

we updated to newer version already, M11 might be broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 done.

@avdv avdv force-pushed the update/nscplugin-0.5.1 branch from 5859e60 to f49cdde Compare April 22, 2024 19:37
@avdv
Copy link
Contributor Author

avdv commented Apr 22, 2024

Can you upgrade the JVM to Java 11 for this specific test target only?

👌 done.

Alternatively, how about downgrading mockito to 4.x?

@avdv
Copy link
Contributor Author

avdv commented Apr 28, 2024

ping ...

@thesamet
Copy link
Contributor

Releasing protobuf-scala-runtime 0.8.15 which support native 0.5.

@thesamet thesamet merged commit 7fafdd6 into scalapb:master Apr 28, 2024
12 checks passed
@avdv avdv deleted the update/nscplugin-0.5.1 branch April 28, 2024 18:59
@MateuszKubuszok
Copy link

Shouldn't scalapb-runtime be released for native0.5 as well? Without it any code that uses:

libraryDependencies += "com.thesamet.scalapb" %% "scalapb-runtime" % scalapb.compiler.Version.scalapbVersion % "protobuf"

does not compile.

thesamet added a commit that referenced this pull request Jun 1, 2024
* Update nscplugin, sbt-scala-native to 0.5.1

* Use `nativeConfig` to enable link stubs

* Update scala-collection-compat to 2.12.0

* Update munit to 1.0.0-M12

* Use Java 11 to run `grpcRuntimeJVM*/test`

* Bump protobuf-scala-runtime to 0.8.15

---------

Co-authored-by: Scala Steward <scala_steward@virtuslab.com>
Co-authored-by: Nadav Samet <thesamet@gmail.com>
@thesamet
Copy link
Contributor

thesamet commented Jun 4, 2024

Please update to ScalaPB 0.11.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants