-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bitwise inversion for session id #138
base: develop
Are you sure you want to change the base?
Conversation
Why you bother about sign of session id? We use Plus in AeronResources we hardcode this one:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we agreed consider either of two points from: #138 (comment)
Motivation:
For now, we apply, for bitwise inversion of session id,
Integer.MAX_VALUE
. And it equals to0x7fffffff
, that means that all bit will be inverted apart from sign bit. It's wrong and we should use0xffffffff
as a value or just bitwise inversion operator (~
).