This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Feature/stackn 120 #139
Merged
Feature/stackn 120 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a project by submitting the Keycloak setup task to Celery. Fix in projects detail view (permission to view page)
dstoyanova
reviewed
Aug 25, 2020
|
|
||
| url = self.models_api+'release/' | ||
| url = url.replace('http:', 'https:') | ||
| url = self.endpoints['models'].format(self.project['id'])+'/' |
There was a problem hiding this comment.
Don't you need the release/ at the end anymore?
There was a problem hiding this comment.
No, I updated the URL schema in the API:
/api/projects//models/
/api/projects//models/
I had the "release" action for no good reason, I should have simply overridden the create-method from the beginning.
|
|
||
| create_keycloak_client_task.delay(project.slug, username.username, []) | ||
|
|
||
| create_environment_image(project, repository) |
There was a problem hiding this comment.
This method has been removed after merging my latest pull request. Make sure you pull develop before merging.
| # create_helm_resources(project, username, repository) | ||
| # Create Keycloak client for project with default project role. | ||
| # The creator of the project assumes all roles by default. | ||
| print('Creating Keycloak resources.') |
There was a problem hiding this comment.
This piece of code is already available in projects/helpers.py. To avoid duplication, is it possible to pass these variables as arguments to the function instead?
There was a problem hiding this comment.
I deleted it from helpers.py instead
niklastheman
added a commit
that referenced
this pull request
May 10, 2023
b40a723 Feature/SK-471 | Add Apache 2.0 license to repositories (#186) 059b0a5 Bug/SK-442 | Serving a model when limit is reached is possible 0fd2451 Bug/SK-448 | Remove download, models template eeaa971 Bug/SK-445 | Publish MLFlow model not working (#148) f87c9c8 Bug/SK-440 | Publish model not working (#147) 563b612 Bug/SK-434 | Color for unpublished weak in models (#139) git-subtree-dir: models git-subtree-split: b40a723
niklastheman
added a commit
that referenced
this pull request
May 15, 2023
* Squashed 'projects/' changes from 89a234a..18acdd8 18acdd8 Feature/SK-471 | Add Apache 2.0 license to repositories (#186) e6ebea4 Bug/SK-458 | Public serve app not visible in dashboard list (#166) 6e7350e Feature/SK-456 | Flavor and environment should not be controlled by user bc2697f Feature/SK- | Store apps per project setting per project (#159) c1a75ec Bug/SK-442 | Serving a model when limit is reached is possible dadfdb9 Feature/SK-435 | Update css patterns for projects (#142) 72115dd Bug/SK-440 | Publish model not working (#147) 053d638 Feature/SK-421 | Network policies - users should not be able to delete or edit (#128) 4a8b837 Feature/SK-428 | Create custom script to delete projects with status "deleted" 1acb7f6 Feature/SK-410 | App logos should not be stored on objects but read from statics folder (#113) f5e6608 Feature/SK-409 | Invite user to project should not be a list, only an input to specify username (#116) 6526911 Feature/SK-416 | Links should be styled like website 1002994 Bug/SK-407 | /projects when not logged in causes an error (#114) 964874b Feature/SK-396 | Change project images for (on dashboard) to css pattern (#103) 62a3ad3 Feature/SK-397 | Add icon to link in app lists (overview and app tabel) (#104) git-subtree-dir: projects git-subtree-split: 18acdd8 * Squashed 'apps/' changes from 39d89ed..e42455b e42455b Feature/SK-471 | Add Apache 2.0 license to repositories (#186) 266fd74 Bug/SK-466 | App settings not working 281e7bd Bug/SK-452 | Remove AccessMode and StorageClass field in Persistent Volume create form 4d22b99 Bug/SK-458 | Public serve app not visible in dashboard list (#166) 153064b Feature/SK- | Store apps per project setting per project (#159) c71db05 Bug/SK-439 | Unable to delete user (#146) 9ebbb74 Fix for failing unit tests c2f40a7 Bug/SK-437 | Model field should be a requirement when creating serve instance b7a0e31 Feature/SK-421 | Network policies - users should not be able to delete or edit (#128) a1da5f0 Bug/SK-431 | If AccessMode is ReadWriteOnce apps create should not be able to mount volume if it's already used (#134) f6eee63 Feature/SK-424 | Add timeout and missing namespace 3b5ffcd Feature/SK-410 | App logos should not be stored on objects but read from statics folder (#113) cb507aa Bug/SK-385 | Delete generated values file on app delete (#119) 02e9693 Bug/SK-414 | Limit apps per project should not be based on user (#115) 8f19ad4 Bug/SK-401 | Limit apps per project - fix ui user feedback d7f862b Feature/SK-397 | Add icon to link in app lists (overview and app tabel) (#104) git-subtree-dir: apps git-subtree-split: e42455b * Squashed 'monitor/' changes from 3c19601..c5cce73 c5cce73 Feature/SK-471 | Add Apache 2.0 license to repositories (#186) git-subtree-dir: monitor git-subtree-split: c5cce73 * Squashed 'models/' changes from 39193ee..b40a723 b40a723 Feature/SK-471 | Add Apache 2.0 license to repositories (#186) 059b0a5 Bug/SK-442 | Serving a model when limit is reached is possible 0fd2451 Bug/SK-448 | Remove download, models template eeaa971 Bug/SK-445 | Publish MLFlow model not working (#148) f87c9c8 Bug/SK-440 | Publish model not working (#147) 563b612 Bug/SK-434 | Color for unpublished weak in models (#139) git-subtree-dir: models git-subtree-split: b40a723 * Squashed 'api/' changes from 5d8d913..47902abe 47902abe Feature/SK-471 | Add Apache 2.0 license to repositories (#186) 9d953414 Feature/SK-410 | App logos should not be stored on objects but read from statics folder (#113) git-subtree-dir: api git-subtree-split: 47902abe681c96ec5a76bb3ecaa98e2c131ee86a * Squashed 'portal/' changes from 83e37a7..0f315f2 0f315f2 Feature/SK-471 | Add Apache 2.0 license to repositories (#186) 3354aac Bug/SK-440 | Publish model not working (#147) 304dafb Feature/SK-410 | App logos should not be stored on objects but read from statics folder (#113) git-subtree-dir: portal git-subtree-split: 0f315f2 * New settings added + App logos script removed + Migrations added * New static files added + App logo path fix * Side/Nav-bar fix + Template tag update * Template files copied from STUDIO
niklastheman
added a commit
that referenced
this pull request
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STACKN-120, STACKN-128
Started cleaning up API. ModelList has been refactored, and authorization is now handled in the ProjectPermissions class in APIpermissions.py. Rest of API still needs refactoring.
We could potentially make authorization fully configurable by the user (some might want to change which groups are allowed to publish models for instance)
Also fixes bug STACKN-128.