chore: remove serverless and terraform backends #89
Conversation
| description: Optional[str] = None | ||
| http_option: Optional[sdk.FunctionHttpOption] = None |
There was a problem hiding this comment.
Those types were changed to avoid needing to import the SDK in the config package. The config package is used by the decorators, and will be imported passively when running the functions on Scaleway. With those changes, it will be possible to vendor scw-serverless with none of its dependencies when deploying to scaleway Functions.
This is good because the next step is to add the dev command and therefore add Flask (transitively) as a dependency.
| class FunctionAPIWrapper: | ||
| """Wraps the Scaleway Python SDK with the Framework types.""" |
There was a problem hiding this comment.
This class was introduced to avoid the bloat in DeploymentManager
cyclimse
force-pushed
the
chore/delete-multiple-backends
branch
from
f76e6fc to
953bbf0
Compare
|
Leaving a comment to remember: When deploying to python310 with a local installation of python3.11, typing_extensions would not be installed as the python version check would be resolved by python3.11. This would cause the function to crash immediately as we imported typing_extensions in the decorators. I thought this could have been solved using the pip flag Realistically it's not too crucial because few packages use version markers for dependencies markers. The fix here ended up to guard the import of typing_extensions with a if TYPE_CHECKING clause. However, pip using the local python version to resolve conditionals import might be an issue for clients using different python_version / runtime combinations. |
|
|
||
| TEMP_DIR = "./.scw" | ||
| DEPLOYMENT_ZIP = f"{TEMP_DIR}/deployment.zip" | ||
| UPLOAD_TIMEOUT = 600 # In seconds |
There was a problem hiding this comment.
I would always put the unit in the variable name to avoid confusion, in this case, UPLOAD_TIMEOUT_SECONDS
Summary
What's changed?
This PR removes the serverless and terraform backends as those functionalities were not being used. Because this removes a lot of code, some structures and abstractions were simplified as well.
Why do we need this?
This improves the overall quality of the codebase and application by removing mostly dead code that was not being tested enough. In addition, we will be able to maintain this project more easily.
How have you tested it?
Adapted the integration tests. They rely on Click test CliRunner so that everything runs in a single process which makes it a lot easier to debug.
Checklist
Details
Most of the other changes are there to clean up what's left behind:
Probably the best change out of them all is to use the click. Runner for the integration tests. This makes the integration tests run in a single process and as such debuggable. Furthermore, it removes a lot of logic in the integration tests.