fix(list): tooltip never disapear after hover on disabled checkbox #2092
+3,608
−3,460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 95.11% 95.12%
=======================================
Files 121 121
Lines 3051 3054 +3
Branches 418 421 +3
=======================================
+ Hits 2902 2905 +3
Misses 115 115
Partials 34 34
Continue to review full report at Codecov.
|
chambo-e
approved these changes
Dec 6, 2022
philibea
approved these changes
Dec 7, 2022
scaleway-bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
## [0.212.10](v0.212.9...v0.212.10) (2022-12-08) ### 📦 Chore * **devdeps:** update dependency @scaleway/use-i18n to v4.1.3 ([#2107](#2107)) ([6f37323](6f37323)) ### 🐛 Bug Fixes * **list:** tooltip never disapear after hover on disabled checkbox ([#2092](#2092)) ([d8d36eb](d8d36eb)) * **tabs:** vertical scroll triggred on page load ([#2100](#2100)) ([fd6da30](fd6da30))
|
🎉 This PR is included in version 0.212.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Tooltip is displayed still when hovering a disabled checkbox on a List. It was hard to find a reason why but it seems like svg events are causing conflict with tooltip, I found this about the topic: facebook/react#4492 (comment)
Adding
pointer-event: noneto a disabled checkbox on List solved the issue.Relevant logs and/or screenshots
Before:
Screen.Recording.2022-12-06.at.10.51.16.mov
After:
Screen.Recording.2022-12-06.at.10.58.31.mov