Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Snippet): snippet height #4499

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(Snippet): snippet height #4499

merged 1 commit into from
Nov 25, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix snippet height problem due to switch from pixels to rem

Before Capture d’écran 2024-11-25 à 14 36 49
After Capture d’écran 2024-11-25 à 14 36 15

@lisalupi lisalupi added the bug Something isn't working label Nov 25, 2024
@lisalupi lisalupi requested a review from a team November 25, 2024 13:38
@lisalupi lisalupi self-assigned this Nov 25, 2024
@lisalupi lisalupi requested review from johnrazeur and DorianMaliszewski and removed request for a team November 25, 2024 13:38
@lisalupi lisalupi requested a review from matthprost as a code owner November 25, 2024 13:38
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 56367fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (d876181) to head (56367fd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4499   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         326      326           
  Lines       11932    11933    +1     
  Branches     3311     3310    -1     
=======================================
+ Hits        10357    10358    +1     
  Misses       1575     1575           
Files with missing lines Coverage Δ
packages/ui/src/components/Snippet/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d876181...56367fd. Read the comment docs.

---- 🚨 Try these New Features:

@matthprost matthprost merged commit 72d5285 into main Nov 25, 2024
13 checks passed
@matthprost matthprost deleted the fix/snippet branch November 25, 2024 15:30
@scaleway-bot scaleway-bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants