Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: groups inputs to display danger when on error #4502

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

  • Fix <RadioGroup />, <ToggleGroup />, <CheckboxGroup /> and <SelectableCardGroup /> to have children in error state when parent is in error
  • Fix SelectableCardGroup that had an empty div when error is shown

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-11-26 at 10 23 21 Screenshot 2024-11-26 at 10 24 00

@matthprost matthprost added the enhancement New feature or request label Nov 26, 2024
@matthprost matthprost self-assigned this Nov 26, 2024
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners November 26, 2024 09:57
Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 9560300

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (e49711a) to head (9560300).
Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4502   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         326      326           
  Lines       11933    11938    +5     
  Branches     3311     3271   -40     
=======================================
+ Hits        10358    10363    +5     
  Misses       1575     1575           
Files with missing lines Coverage Δ
packages/ui/src/components/Checkbox/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/CheckboxGroup/index.tsx 93.93% <100.00%> (+0.18%) ⬆️
packages/ui/src/components/RadioGroup/index.tsx 90.00% <100.00%> (+0.34%) ⬆️
...es/ui/src/components/SelectableCardGroup/index.tsx 96.77% <100.00%> (+0.10%) ⬆️
packages/ui/src/components/ToggleGroup/index.tsx 93.54% <100.00%> (+0.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49711a...9560300. Read the comment docs.

@matthprost matthprost merged commit 36f3b03 into main Dec 2, 2024
12 checks passed
@matthprost matthprost deleted the fix/selectable-card-group-error branch December 2, 2024 09:25
@scaleway-bot scaleway-bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants